feat: make getNonce optional in AuthenticationAdapter#2674
Open
2wheeh wants to merge 4 commits into
Open
Conversation
|
@2wheeh is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: df43ae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9162c76 to
df43ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2633.
#2633 enabled server-side SIWE message generation, but the adapter still required
getNonce. dApps following that pattern end up shipping dead boilerplate — a no-op/api/nonceendpoint orgetNonce: async () => 'nonce'— just to satisfy the type, with no real-world signal flowing through it.This PR makes
getNonceoptional. When omitted, the client-side nonce pre-fetch is skipped andcreateMessagereceives only{ address, chainId }.API
AuthenticationAdapterbecomes a discriminated union — fully backwards compatible:getNonce—createMessage({ nonce, address, chainId }). Unchanged.getNonce—createMessage({ address, chainId }). Pre-fetch skipped; button enabled immediately.