You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes Terraform storage from pod-local emptyDir volumes to a shared PersistentVolumeClaim with ReadWriteMany access mode. This enables applications-rp and dynamic-rp to share the same Terraform binaries installed via rad terraform install.
Changes:
New terraform-pvc.yaml template creating a shared PVC (terraform-storage)
Updated both RP deployments to mount the shared PVC instead of emptyDir
Added NFS provisioner to Kind cluster setup for RWX support in CI
Updated Helm tests to validate PVC configuration
Why:
Previously, each RP had its own emptyDir volume, so rad terraform install only affected applications-rp. With a shared PVC, both RPs can access the same installed Terraform binary.
Type of change
This pull request adds or changes features of Radius and has an approved issue (issue link required).
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
An overview of proposed schema changes is included in a linked GitHub issue.
Yes
Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
Yes
Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
Yes
Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
Yes
Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
Yes
Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6fc3ad20cb
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6fc3ad20cb
controller test image location: ghcr.io/radius-project/dev/controller:pr-func6fc3ad20cb
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6fc3ad20cb
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest
Test Status
⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes Terraform storage from pod-local
emptyDirvolumes to a sharedPersistentVolumeClaimwithReadWriteManyaccess mode. This enablesapplications-rpanddynamic-rpto share the same Terraform binaries installed viarad terraform install.Changes:
terraform-pvc.yamltemplate creating a shared PVC (terraform-storage)emptyDirWhy:
Previously, each RP had its own
emptyDirvolume, sorad terraform installonly affectedapplications-rp. With a shared PVC, both RPs can access the same installed Terraform binary.Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: