Skip to content

Add peer_cert_serial_number and fix validity#16449

Closed
razvanphp wants to merge 1 commit into
rabbitmq:mainfrom
vampirebyte:main
Closed

Add peer_cert_serial_number and fix validity#16449
razvanphp wants to merge 1 commit into
rabbitmq:mainfrom
vampirebyte:main

Conversation

@razvanphp
Copy link
Copy Markdown
Contributor

Proposed Changes

Fix the peer cert end date rendered as a tuple
X.509 encodes dates two different ways depending on whether the year fits in two digits:

  • UTCTime — YYMMDDHHMMSSZ, used for years 1950–2049.
  • GeneralizedTime — YYYYMMDDHHMMSSZ, used for 2050 and later.
Screenshot 2026-05-16 at 23 45 28

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

We run a fairly large mTLS fleet of IoT devices and the serial number is a must to be able to check the exact cert a device is using or if it rotated it's cert correctly. I'm sure it will come in handy for other users as well.

Screenshot 2026-05-17 at 00 30 15

@michaelklishin
Copy link
Copy Markdown
Collaborator

Moved to #16460.

michaelklishin added a commit that referenced this pull request May 18, 2026
michaelklishin added a commit that referenced this pull request May 18, 2026
(cherry picked from commit 52951e9)
pull Bot pushed a commit to Zezo-Ai/rabbitmq-server that referenced this pull request May 18, 2026
pull Bot pushed a commit to Zezo-Ai/rabbitmq-server that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants