Add peer_cert_serial_number and fix validity#16449
Closed
razvanphp wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Moved to #16460. |
michaelklishin
added a commit
that referenced
this pull request
May 18, 2026
(cherry picked from commit 1794415)
michaelklishin
added a commit
that referenced
this pull request
May 18, 2026
(cherry picked from commit 52951e9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix the peer cert end date rendered as a tuple
X.509 encodes dates two different ways depending on whether the year fits in two digits:
UTCTime— YYMMDDHHMMSSZ, used for years 1950–2049.GeneralizedTime— YYYYMMDDHHMMSSZ, used for 2050 and later.Types of Changes
What types of changes does your code introduce to this project?
Checklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
We run a fairly large mTLS fleet of IoT devices and the serial number is a must to be able to check the exact cert a device is using or if it rotated it's cert correctly. I'm sure it will come in handy for other users as well.