Open
Conversation
As part of major refactor to Kubebuilder v4
Because we are abandoning DockerHub, for reasons outside of our control. GHCR allows to pull without authentication, since our repo is public.
It went unnoticed during code porting. Our license remains MPL 2.0 [skip ci]
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Zerpet
force-pushed
the
migrate-kubebuilder-v4
branch
from
54ea246 to
21ee19a
Compare
CodeQL has a warning about not analysing Go files. Trying manual build mode. Kubectl plugin got renamed during the code port.
Zerpet
force-pushed
the
migrate-kubebuilder-v4
branch
from
21ee19a to
da1ddf5
Compare
AI removed the v2 suffix in the import path during code porting.
Zerpet
force-pushed
the
migrate-kubebuilder-v4
branch
from
bbb45dc to
4e1b2a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
go.modto MakefileAdditional Context
Migrating to Kubebuilder V4 is a long over-due chore. We were unable to use the
kubebuildercli at all. We were in a position where we couldn't add new types, nor new webhooks. Any new features from kubebuilder were very complicated to adopt. This PR unblocks the repo to use kubebuilder CLI again.Adding support for different Service types in system tests allows to run system tests in environments (like my local Rancher Desktop) where NodePort (the default) doesn't route properly. In my setup, LoadBalancer routes correctly to the Pods.
Moving tools to Makefile is motivated to reduce the number of dependencies in
go.mod. Tool dependencies ingo.modpollute the actual dependencies of our operator, and triggers false positives in CVE scanners.For reasons outside of our control, we won't be producing images to DockerHub anymore. Our "dockerhub" manifest will use the image from GHCR instead. The new image does not require authentication, so we expect no disruption to users upgrading to the next version.
Local Testing