Move footer function to cnd_footer() method#212
Merged
DavisVaughan merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
DavisVaughan
commented
Feb 6, 2026
| ) | ||
| } | ||
| } | ||
| trace <- trace_back(bottom = trace_env) |
Member
Author
There was a problem hiding this comment.
I was a bit worried about the fact that trace is in the condition object, but it doesn't seem to be that big, so it's probably okay.
DavisVaughan
commented
Feb 6, 2026
| message = msg, | ||
| trace = trace, | ||
| footer = footer, | ||
| internal = list(...) |
Member
Author
There was a problem hiding this comment.
We weren't using internal for anything
lionel-
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
I've shifted us from using an on-the-fly created
footerfunction to acnd_footer()S3 method. This forces us to retain the minimal amount of things required to reproduce thefootermessage inside thecndobject, which seems to be thepkgname of interest andalways.We've got quite a few snapshot tests that test the emitted warning messages, so I feel pretty good about this.