id3: fix reading/writing v1.0 and v1.1#686
Open
corubba wants to merge 1 commit intoquodlibet:mainfrom
Open
Conversation
Properly read and write ID3 v1.0 and v1.1 tags according to the spec [0]. ID3v1.0 tags are no longer always read as v1.1, which previously resulted in wrong track numbers. Writing will use v1.0 by default, automatically upgrading to v1.1 if needed. I am not entirely sure what the WinAmp special-case was for, but the (also fixed) testcase still passes so ... probably still covered. [0] https://id3.org/ID3v1
corubba
force-pushed
the
bugfix/id3-v1
branch
from
2f63d47 to
c62ff93
Compare
corubba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly read and write ID3 v1.0 and v1.1 tags according to the spec. ID3 v1.0 tags are no longer always read as v1.1, which previously resulted in wrong track numbers. Writing will use v1.0 by default, automatically upgrading to v1.1 if needed.
I am not entirely sure what the WinAmp special-case was for, but the (also fixed) testcase still passes so ... probably still covered.
Fixes #668