Changes to support VS 2017 builds for Win64 bench-marking.#38
Changes to support VS 2017 builds for Win64 bench-marking.#38JakeKirk wants to merge 2 commits intoquixdb:masterfrom
Conversation
Changes have been tested on Kubuntu and Win32. - Added cross platform "getopts" parg.c/h to assist with this goal. - Reworked benchmark_codec_with_options() -#ifdef conditionalize fork(), exit() and wait() logic. - added FILENAME_MAX for fifo_name size, whether mktemp() or GetTempFileNameA() is used. - Created append_csv_benchmark() to assist with readabilty and simplify Win32/Linux changes. - mktemp() on Win32 creates only 26 unique temp files names (which normally are deleted if no errors occur, but can fail if file pre-exists. Therefore decided to use GetTempFileNameA() instead which creates a larger set of temporary file names. - Added a few comments, made a few indentation changes (hope tabs match!), added a few constants.
The fifo_name results file must be opened using O_BINARY otherwise the CSV data will be misaligned.
|
On Win32... |
This is my first pull request, bear with me as I learn how this all works.
Here are the change notes:
Changes have been tested on Kubuntu gcc/cc 7.3.0 and VS 2017 (Win64).
-#ifdef conditionalize fork(), exit() and wait() logic.
Therefore decided to use GetTempFileNameA() instead which creates a larger set of temporary file names.