chore(build): clarify release GitHub App private key setup#44
Open
sklarsa wants to merge 3 commits into
Open
Conversation
sklarsa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add a preflight check that MAVEN_RELEASE_GITHUB_APP_PRIVATE_KEY is a parseable GitHub App private key PEM, scope the app token explicitly to this repository, and clarify the release README so client secrets are not confused with app private keys. Testing: git diff --check; python3 YAML parse; local OpenSSL validation for raw PEM, escaped-newline PEM, and invalid input.