use getClientRects for IE10+ clientWidth/Height calculation#96
Open
jonirrings wants to merge 1 commit intoque-etc:masterfrom
Open
use getClientRects for IE10+ clientWidth/Height calculation#96jonirrings wants to merge 1 commit intoque-etc:masterfrom
jonirrings wants to merge 1 commit intoque-etc:masterfrom
Conversation
|
|
Author
|
@yoyo837 emmm, so let's add an API detection? or just deprecate those before IE11 ? |
jonirrings
changed the title
|
This is a polyfill, I think it should be an polyfill for all browsers that which version who need it. |
Author
|
agreed, old code restored. |
|
By the way, the maintainer of this repo doesn't seem to be active. |
Author
|
sigh…… |
Contributor
|
...? |
Author
|
@weswigham as stated above, can you help to review this pr? |
Contributor
|
I'm just someone who contributed a PR once in the past, not a maintainer. |
Author
|
@weswigham whatever, thx for your attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a quick fix for the bug mentioned in #2