Skip to content

Fixed definition file for newer TS versions#85

Open
4lolo wants to merge 1 commit intoque-etc:masterfrom
4lolo:master
Open

Fixed definition file for newer TS versions#85
4lolo wants to merge 1 commit intoque-etc:masterfrom
4lolo:master

Conversation

@4lolo
Copy link
Copy Markdown

@4lolo 4lolo commented Jun 2, 2021

In typescript 4.2 definition file causes error:
Error: node_modules/resize-observer-polyfill/src/index.d.ts:19:18 - error TS2717: Subsequent property declarations must have the same type. Property 'contentRect' must be of type 'DOMRectReadOnly', but here has type 'DOMRectReadOnly'.

Declaring DOMRectReadOnly as global fixes that issue.

@mcarriere
Copy link
Copy Markdown

We also have this issue. Can we get this merged?

@VilOstreiko
Copy link
Copy Markdown

the same for us. having TS error using Angular 12. please review the issue @que-etc
thank you!

@lizraeli
Copy link
Copy Markdown

This would solve the issue described in #83

tommoor added a commit to outline/rich-markdown-editor that referenced this pull request Jul 28, 2021
@centigrade-julian-lang
Copy link
Copy Markdown

Hi, this branch is now open for quite some time - could this be merged somewhere near future? :)

@nicoesiea
Copy link
Copy Markdown

I have the same issue, could you please merge the fix and release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants