Update index.d.ts#81
Open
albancreton wants to merge 2 commits intoque-etc:masterfrom
Open
Conversation
To use `DOMRectReadOnly` from TS `lib.dom.d.ts`
Duplicating DOMRectReadOnly from `lib.dom`
|
go go go |
vilbergs
approved these changes
Mar 3, 2021
vilbergs
left a comment
There was a problem hiding this comment.
Seems correct according to https://github.com/microsoft/TypeScript/blob/master/lib/lib.dom.d.ts
|
It seems that EDIT: My bad... These are not implemented in the package yet, as per #77 |
|
Pinging @que-etc on the off change that he still logs into his account regularly/reads his email. We would love to get this merged and published as it's blocking in one of our projects. |
|
I've emailed @que-etc directly incase he's disabled his github email notifications |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #80
Updating
DOMRectReadOnlybased on the declaration in typescript'slib.dom.