Skip to content

Update index.d.ts#81

Open
albancreton wants to merge 2 commits intoque-etc:masterfrom
albancreton:patch-1
Open

Update index.d.ts#81
albancreton wants to merge 2 commits intoque-etc:masterfrom
albancreton:patch-1

Conversation

@albancreton
Copy link
Copy Markdown

@albancreton albancreton commented Feb 25, 2021

RE: #80

Updating DOMRectReadOnly based on the declaration in typescript's lib.dom.

To use `DOMRectReadOnly` from TS `lib.dom.d.ts`
Duplicating DOMRectReadOnly from `lib.dom`
@garronej
Copy link
Copy Markdown

go go go

Copy link
Copy Markdown

@vilbergs vilbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vilbergs
Copy link
Copy Markdown

vilbergs commented Mar 3, 2021

It seems that ResizeObserverEntry is out of sync as well, it's missing the following properties. Perhaps this PR could incorporate that.

interface ResizeObserverEntry {
    readonly borderBoxSize: ReadonlyArray<ResizeObserverSize>;
    readonly contentBoxSize: ReadonlyArray<ResizeObserverSize>;
    ...
}

EDIT:

My bad... These are not implemented in the package yet, as per #77

@cascornelissen
Copy link
Copy Markdown

cascornelissen commented Mar 11, 2021

Pinging @que-etc on the off change that he still logs into his account regularly/reads his email. We would love to get this merged and published as it's blocking in one of our projects.

@davidnormo
Copy link
Copy Markdown

davidnormo commented May 18, 2021

I've emailed @que-etc directly incase he's disabled his github email notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants