ncm-hostsfile: Fix NoAction support declaration#1708
Draft
jrha wants to merge 1 commit intoquattor:mainfrom
Draft
ncm-hostsfile: Fix NoAction support declaration#1708jrha wants to merge 1 commit intoquattor:mainfrom
jrha wants to merge 1 commit intoquattor:mainfrom
Conversation
The component uses LC rather than CAF, so cannot support NoAction properly.
Contributor
|
ISTR LC supports NoAction, it's just not as detailed as CAF (i.e. no diffs). Do you have a specific case where --noaction is doing the wrong thing? (This was set in 46fcb20 which is a long time ago but I am confident it was right then, unless something has changed in code since). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component uses LC rather than CAF, so cannot support NoAction properly.