ncm-sudo: support all values for lecture option and the lecture_file option#1689
Open
stdweird wants to merge 1 commit intoquattor:mainfrom
Open
ncm-sudo: support all values for lecture option and the lecture_file option#1689stdweird wants to merge 1 commit intoquattor:mainfrom
stdweird wants to merge 1 commit intoquattor:mainfrom
Conversation
Contributor
|
If I understand the comment correctly, a file with the old true/false values is accepted by sshd. However any site that sets config via quattor to true/false will need to modify all their templates to use once/never instead. That's a one-time sed fixup, but needs to happen in sync with the schema change and the code on the hosts needs to be ready to accept new version before the schema change can happen. Is there a way to permit both forms to co-exist for a release or two to provide a smooth transition path? Maybe something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is backwards incompatible
@jrha needs to be checked if this supported on el7 or
el6