Fix ordering in Engine.run_batch#8060
Open
dstrain115 wants to merge 2 commits intoquantumlib:mainfrom
Open
Conversation
Collaborator
dstrain115
commented
Apr 24, 2026
- ProcessorSampler incorrectly reconstructs the results from Quantum Engine. It incorrectly assumes that the engine returns results interleaved by sweep point (e.g., S1_P1, S1_P2, S2_P1, S2_P2), when the engine actually returns them grouped by program (e.g., P1_S1, P1_S2, P2_S1, P2_S2).
- This causes the results to be returned incorrectly if jobs_per_batch>1.
- ProcessorSampler incorrectly reconstructs the results from Quantum Engine. It incorrectly assumes that the engine returns results interleaved by sweep point (e.g., S1_P1, S1_P2, S2_P1, S2_P2), when the engine actually returns them grouped by program (e.g., P1_S1, P1_S2, P2_S1, P2_S2). - This causes the results to be returned incorrectly if jobs_per_batch>1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8060 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 1110 1110
Lines 99934 99954 +20
=======================================
+ Hits 99572 99592 +20
Misses 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.