ci: Switch workflows to pull_request event#341
Open
ekanshibu wants to merge 1 commit intoqualcomm:developmentfrom
Open
ci: Switch workflows to pull_request event#341ekanshibu wants to merge 1 commit intoqualcomm:developmentfrom
ekanshibu wants to merge 1 commit intoqualcomm:developmentfrom
Conversation
Replace pull_request_target with pull_request in PR workflows to follow GitHub security practices and avoid elevated permissions during PR validation. Signed-off-by: Anand Kulkarni <anankulk@qti.qualcomm.com>
Contributor
|
moving from pull_request_target to pull_request would not have access to secrets you need to refactor workflow |
njjetha
reviewed
Apr 24, 2026
| pkg-repo: ${{vars.PKG_REPO_GITHUB_NAME}} | ||
| pr-number: ${{github.event.pull_request.number}} | ||
| secrets: | ||
| TOKEN: ${{ secrets.DEB_PKG_BOT_CI_TOKEN }} |
Contributor
There was a problem hiding this comment.
It will not have access to secrets.
Contributor
Author
There was a problem hiding this comment.
@simonbeaudoin0935 based on the recent guidelines to move to pull_request from pull_Request_target do you have any plans to change this workflow?
Contributor
There was a problem hiding this comment.
@ekanshibu Simply remove the line 38-39, the service bot secret is not used anymore in this case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace pull_request_target with pull_request in PR workflows to follow GitHub security practices and avoid elevated permissions during PR validation.