Refactor memory mapping with DSP address tracking#299
Open
quic-vkatoch wants to merge 2 commits intoqualcomm:developmentfrom
Open
Refactor memory mapping with DSP address tracking#299quic-vkatoch wants to merge 2 commits intoqualcomm:developmentfrom
quic-vkatoch wants to merge 2 commits intoqualcomm:developmentfrom
Conversation
ekanshibu
reviewed
Feb 20, 2026
Remove rpcmem_set_dmabuf_name() which was a no-op dummy function. Cleaned up declaration, implementation, and all call sites. Signed-off-by: Vinayak Katoch <[email protected]>
quic-vkatoch
force-pushed
the
fix-mmap
branch
from
6a63077 to
cc429b1
Compare
quic-vkatoch
changed the title
ekanshibu
reviewed
Feb 26, 2026
ekanshibu
previously approved these changes
Feb 26, 2026
auto-merge was automatically disabled
February 26, 2026 17:25
Head branch was pushed to by a user without write access
quic-vkatoch
force-pushed
the
fix-mmap
branch
from
cc429b1 to
d1f5390
Compare
quic-vkatoch
force-pushed
the
fix-mmap
branch
from
d1f5390 to
3b6206f
Compare
ekanshibu
reviewed
Feb 27, 2026
Introduce fastrpc_mmap_internal() and fastrpc_munmap_internal() to handle buffer mapping with DSP virtual address management. These functions maintain mappings in the static map list and enable lookup by DSP virtual address. Extract common mmap logic into fastrpc_mmap_helper() to eliminate code duplication between fastrpc_mmap() and fastrpc_mmap_internal(). Simplify apps_mem_request_map64() by removing conditional allocation logic and always allocating in userspace, then using fastrpc_mmap_internal() for mapping. Update apps_mem_request_unmap64() to route to appropriate unmap function based on mapping type: - FASTRPC_ALLOC_HLOS_FD: use fastrpc_munmap() - ADSP_MMAP_HEAP_ADDR/ADSP_MMAP_REMOTE_HEAP_ADDR: use remote_munmap64() - Other allocations: use fastrpc_munmap_internal() Signed-off-by: Vinayak Katoch <[email protected]>
quic-vkatoch
force-pushed
the
fix-mmap
branch
from
3b6206f to
6ad405c
Compare
quic-parihar
reviewed
Mar 2, 2026
| fd = rpcmem_to_fd_internal(buf); | ||
| VERIFYC(fd > 0, AEE_EBADPARM); | ||
| } | ||
| VERIFYC(NULL != (buf = rpcmem_alloc_internal(heapid, lflags, len)), |
Contributor
There was a problem hiding this comment.
for signed or unsigned we will allocate in user space always now, why? is okay to allocate signed memory in user space
Contributor
Author
There was a problem hiding this comment.
There isn’t a clear or specific technical reason for this. However, allocating it in user space is acceptable and works for our use case.
| * | ||
| * @return 0 on success, error code on failure | ||
| */ | ||
| int fastrpc_mmap_internal(int domain, int fd, void *vaddr, int offset, size_t length, uint32_t flags, uint64_t *raddr); |
Contributor
There was a problem hiding this comment.
for offset shouldn't we use unsigned vars?
Contributor
Author
There was a problem hiding this comment.
Since fastrpc_mmap uses an int for the offset, we are keeping it the same here.
|
|
||
| VERIFY(AEE_SUCCESS == (nErr = fastrpc_init_once())); | ||
|
|
||
| VERIFYC(raddr != NULL, AEE_EBADPARM); |
Contributor
There was a problem hiding this comment.
verify requested length is greater than 0
Contributor
Author
There was a problem hiding this comment.
This is already handled earlier inside the rpcmem_alloc_internal function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor memory mapping implementation to use internal functions with DSP virtual address tracking and simplify allocation logic.