Skip to content

Comments

Fix missing reset on Kinetis devices. Unify reset behavior.#25959

Closed
hydra wants to merge 2 commits intoqmk:masterfrom
hydra:fixes-for-pr-1
Closed

Fix missing reset on Kinetis devices. Unify reset behavior.#25959
hydra wants to merge 2 commits intoqmk:masterfrom
hydra:fixes-for-pr-1

Conversation

@hydra
Copy link

@hydra hydra commented Jan 20, 2026

Description

As per the title.

Additionally, with regard to the unification of reset behavior. I've taken similar approaches in other firmware that I'm a maintainer or author of, it allows graceful shutdown in a single place.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Maybe some, not searched for them, however #19420 is partially fixed by this, but also needs fixes from chibios-control to be fully fixed, see: ChibiOS/ChibiOS-Contrib#432

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

hydra added 2 commits January 20, 2026 23:11
* fixing resetting not working on the Ergodox Infinity.
* reset delegated to the main task.
* user code from `pre_mcu_reset_user` is executed before a reset.
@github-actions github-actions bot added the core label Jan 20, 2026
@zvecr
Copy link
Member

zvecr commented Jan 20, 2026

Per the PR checklist:

PRs should contain the smallest amount of modifications required for a single change to the codebase
...
all core PRs must now target develop branch, which will subsequently be merged back to master on the breaking changes timeline

The bootloader changes must be submitted separately to the core changes, and the core changes must target develop.

@hydra
Copy link
Author

hydra commented Jan 20, 2026

Per the PR checklist:

PRs should contain the smallest amount of modifications required for a single change to the codebase
...
all core PRs must now target develop branch, which will subsequently be merged back to master on the breaking changes timeline

The bootloader changes must be submitted separately to the core changes, and the core changes must target develop.

okey doke, sigh, I'll go jump through some hoops and will link this PR to new ones as appropriate.

May I suggest changing the default branch to develop for PRs, this would cut-down on the amount of first-time contributor overhead.

@hydra
Copy link
Author

hydra commented Jan 20, 2026

New PRs targetting develop are here:

@hydra hydra closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants