Skip to content

SWA implementation#3249

Open
yuanqing-wang wants to merge 1 commit intopyro-ppl:devfrom
yuanqing-wang:dev
Open

SWA implementation#3249
yuanqing-wang wants to merge 1 commit intopyro-ppl:devfrom
yuanqing-wang:dev

Conversation

@yuanqing-wang
Copy link
Copy Markdown

No description provided.

@yuanqing-wang
Copy link
Copy Markdown
Author

@fritzo
Copy link
Copy Markdown
Member

fritzo commented Jul 25, 2023

Hi @yuanqing-wang, I'd recommend taking a look at our CONTRIBUTING.md, and in particular:

  • make format and make lint to work past linting errors
  • add torchcontrib to the EXTRAS_REQUIRE list in setup.py (and ideally lower bound a version so we know SWA is available)
  • add a test, probably in a new file tests/optim/test_swa.py
  • probably add a pytest.importorskip("torchcontrib") to your test
  • add a new automodule section to docs/source/pyro.optim.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants