Support inference with RenyiELBO for local latent variable models #3123
Support inference with RenyiELBO for local latent variable models #3123OlaRonning wants to merge 7 commits intopyro-ppl:devfrom
Conversation
|
Should I ignore notebooks when using black? When running |
|
Yes could you please ignore notebooks? The easiest way to do so is to run black through |
Sure, no problem.
Looking at the format target in the Makefile, it seems it's only black that needs a section in the TOML file. I'll configure a pyproject.toml and update the Makefile. |
|
|
||
|
|
||
| @pytest.mark.stage("integration", "integration_batch_2") | ||
| class OneWayNormalRandomEffects(TestCase): |
There was a problem hiding this comment.
how much time do these tests take?
There was a problem hiding this comment.
how much time do these tests take?
In CI :
| Time [sec] | |
|---|---|
test_renyi_nonreparameterized |
50.67 |
test_renyi_reparameterized |
36.59 |
test_renyi_vectorized |
36.32 |
So all are in the top ten slowest for batch 2.
|
@martinjankowiak, can you suggest a plating structure where we need to compute the dependence (i.e., |
martinjankowiak
left a comment
There was a problem hiding this comment.
@OlaRonning will this still give results for a local latent variable model like a VAE with a data plate? why doesn't this logic sum out the data plate dimension?
|
@martinjankowiak, sorry for the late reply.
From my understanding, this corresponds to including the data plate dimension in |
Addresses #3104
TODO
logsumexpreduction dim for LLV model