doc(gh-2187): docstrings for Dirichlet and Geometric - #2227
Merged
Qazalbash merged 9 commits intoJul 25, 2026
Conversation
fehiepsi
approved these changes
Jul 22, 2026
Qazalbash
requested changes
Jul 22, 2026
Qazalbash
requested changes
Jul 23, 2026
Qazalbash
left a comment
Qazalbash
left a comment
Collaborator
There was a problem hiding this comment.
Overall, it looks good. I have proposed some changes; could you please take a look?
Contributor
Author
|
Thanks for the review, I have addressed the changes in the latest commit (7d53c8e). |
Collaborator
Contributor
Author
|
Thank you, I have addressed the requested change. |
Qazalbash
approved these changes
Jul 24, 2026
Collaborator
|
Merge the master branch after #2228 merges into it, so CI can pass. |
…-dirichlet-geometric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2187.
Adds documentation for 2 more distributions from the docs checklist, follows similar structure as #2202
Dirichlet— class,__init__,sample,log_prob,mean,variance,entropyGeometricProbs— class,__init__,sample,log_prob,logits,mean,variance,entropyGeometricLogits— class,__init__,probs,sample,log_prob,logits,mean,variance,entropyGeometric— functionDocstrings only, no logic changes.
Verified: