BUG: fix replace on non-contiguous array views#513
Merged
neutrinoceros merged 2 commits intopydata:masterfrom Feb 5, 2026
Merged
BUG: fix replace on non-contiguous array views#513neutrinoceros merged 2 commits intopydata:masterfrom
neutrinoceros merged 2 commits intopydata:masterfrom
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
neutrinoceros
requested changes
Feb 5, 2026
Collaborator
neutrinoceros
left a comment
neutrinoceros
left a comment
There was a problem hiding this comment.
the fix seems correct to me. Thanks a lot ! I would suggest tightening the first test case while we're at it.
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
force-pushed
the
fix-replace-stride
branch
from
d444122 to
3dc76b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When calling
bn.replaceon a non-contiguous view (e.g.array[::2]or a slice from a 3D array), not all matching values were replaced. The array indexing didn't account for stride, so it accessed wrong memory locations. This restores the fix from PR #295 which was accidentally reverted in the commit bcf5aa9.Fixes #496.