Skip to content

MNT/SEC: setup pre-commit + zizmor and address for security-related lints #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neutrinoceros merged 6 commits into from
Jan 19, 2026
Merged

MNT/SEC: setup pre-commit + zizmor and address for security-related lints #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3051fc3
MNT/SEC: configure pre-commit + zizmor
neutrinoceros Dec 13, 2025
acbd17f
SEC: zizmor autofixes
neutrinoceros Dec 13, 2025
231f562
SEC: pin GHA exactly
neutrinoceros Dec 13, 2025
54a18ad
MNT: (temporarily ?) turn off zizmor's `use-trusted-publishing` lint …
neutrinoceros Dec 13, 2025
6ed1bdc
SEC: turn off default GHA permissions
neutrinoceros Dec 13, 2025
7cb55cf
TST: add a CI job to run pre-commit
neutrinoceros Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/bottleneck-action/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ runs:
using: composite
steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: ${{ matrix.python-version }}
- name: Install
Expand Down
40 changes: 30 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,19 @@ name: Github Actions

on: ["push", "pull_request"]

permissions: {}

jobs:

pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1

test-linux-macos:
runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -17,7 +29,9 @@ jobs:
- macos-15-intel
- macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
- uses: ./.github/bottleneck-action

test-windows:
Expand Down Expand Up @@ -46,7 +60,9 @@ jobs:
architecture: arm64
python-version: "3.14t"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
- uses: ./.github/bottleneck-action

test-pyversions:
Expand All @@ -63,7 +79,9 @@ jobs:
- "3.14"
- "3.14t"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false
- uses: ./.github/bottleneck-action

check:
Expand Down Expand Up @@ -94,15 +112,16 @@ jobs:
- ubuntu-latest
- ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
fetch-depth: 0
persist-credentials: false

- name: Build wheels
uses: pypa/cibuildwheel@v3.1.4
uses: pypa/cibuildwheel@63fd63b352a9a8bdcc24791c9dbee952ee9a8abc # v3.3.0

- name: Store wheel artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
with:
name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
path: ./wheelhouse/*.whl
Expand All @@ -114,14 +133,15 @@ jobs:
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
fetch-depth: 0
persist-credentials: false

- name: Build sdist
run: pipx run build --sdist

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
with:
path: dist/*.tar.gz

Expand All @@ -132,12 +152,12 @@ jobs:
if: github.event_name == 'push'
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
path: dist
merge-multiple: true

- uses: pypa/gh-action-pypi-publish@release/v1
- uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0 # zizmor: ignore[use-trusted-publishing]
Copy link
Copy Markdown
Collaborator Author

@neutrinoceros neutrinoceros Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would also setup trusted publishing, but this requires clearance on the PyPI side, which I do not have, so I'm ignoring the rule for now.

Copy link
Copy Markdown
Collaborator

@rgommers rgommers Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be useful as a follow-up indeed. Although given the current CI trouble, perhaps best to wait until everything is green again.

with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN}}
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
repos:
- repo: https://github.com/zizmorcore/zizmor-pre-commit
rev: v1.18.0
hooks:
- id: zizmor
Loading