MNT: move static project metadata to pyproject.toml#491
Merged
rgommers merged 1 commit intopydata:masterfrom Jan 14, 2026
Merged
MNT: move static project metadata to pyproject.toml#491rgommers merged 1 commit intopydata:masterfrom
pyproject.toml#491rgommers merged 1 commit intopydata:masterfrom
Conversation
neutrinoceros
added
the
packaging
neutrinoceros
force-pushed
the
cibw-static-config
branch
2 times, most recently
from
7aef0b5 to
551517e
Compare
neutrinoceros
changed the title
pyproject.tomlpyproject.toml
neutrinoceros
force-pushed
the
cibw-static-config
branch
from
551517e to
29e0e60
Compare
neutrinoceros
commented
Dec 10, 2025
Comment on lines
+59
to
+64
| [dependency-groups] | ||
| doc = [ | ||
| "numpydoc", | ||
| "sphinx", | ||
| "gitpython", | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
this isn't a 1-for-1 replacement of the existing "optional-dependencies" , but better fits the purpose of a dev-only set of requirements. I'll need to adapt any CI that actually builds documentation.
Collaborator
There was a problem hiding this comment.
agreed, dependency-groups should be an improvement
neutrinoceros
force-pushed
the
cibw-static-config
branch
3 times, most recently
from
d56bd9f to
f69e6e4
Compare
Collaborator
Author
|
I'm seeing a diff locally on the resulting wheel size (not in source dists). Will fix this before I undraft. |
neutrinoceros
force-pushed
the
cibw-static-config
branch
from
f69e6e4 to
47e5c81
Compare
Collaborator
Author
|
resolved by setting [tool.setuptools]
include-package-data = false |
neutrinoceros
force-pushed
the
cibw-static-config
branch
from
47e5c81 to
a50320e
Compare
rgommers
approved these changes
Jan 14, 2026
Collaborator
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
This looks like a significant improvement, CI is happy, and diffoscope doesn't show any nontrivial difference for sdist and wheel. So in it goes, thanks @neutrinoceros!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.