fix: make sidebar reachable on mobile and use dynamic viewport units - #37
Open
Kludex wants to merge 3 commits into
Open
fix: make sidebar reachable on mobile and use dynamic viewport units#37Kludex wants to merge 3 commits into
Kludex wants to merge 3 commits into
Conversation
On viewports below md the only SidebarTrigger was rendered inside the sidebar itself, which becomes a closed off-canvas drawer on mobile - so the conversation list, new-conversation button, and theme toggle were unreachable on phones. Add a mobile-only header with a SidebarTrigger outside the drawer. Also replace h-screen/basis-[100vh] with dvh units so the layout tracks the visual viewport when mobile browsers show/hide the URL bar and keyboard.
On narrow viewports the model and effort selects pushed the submit button out of the viewport; let the tools wrap and stop the submit button from shrinking.
Instead of wrapping, shorten the effort label to just the level below sm and let the model select shrink and truncate, so the send button stays visible without stacking the controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile the only
SidebarTriggerwas inside the sidebar itself, which shadcn renders as a closed off-canvas drawer belowmd- so conversation history, new-conversation, and the theme toggle were unreachable on phones. This adds a mobile-only header with a trigger outside the drawer, and swapsh-screen/basis-[100vh]fordvhunits so the layout tracks the visual viewport when mobile browsers show/hide the URL bar and keyboard.