jira/client.py: Map IssueLinkType array to string array#1876
Open
ssamsel-rtx wants to merge 1 commit intopycontribs:mainfrom
Open
jira/client.py: Map IssueLinkType array to string array#1876ssamsel-rtx wants to merge 1 commit intopycontribs:mainfrom
ssamsel-rtx wants to merge 1 commit intopycontribs:mainfrom
Conversation
Equality check between IssueLinkType and string always returns false. Function decorator casts IssueLinkType parameters to string, so a warning is always logged. This fixes that issue. Closes: pycontribs#1875 Signed-off-by: Shymon Samsel <[email protected]>
adehad
approved these changes
Aug 14, 2024
Contributor
adehad
left a comment
adehad
left a comment
There was a problem hiding this comment.
Excellent, thanks for this. I want to have a think of a test case to make sure we don't cause regressions on this moving forward, so will have a think before merging
|
This fix won't work. You'll break the for loop later when it tries to access |
|
An IssueLinkType as parameter is supposed to be working according to the parameter typing, but it won't work with this patch. I created another PR #2406. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equality check between IssueLinkType and string always returns false. Function decorator casts IssueLinkType parameters to string, so a warning is always logged. This fixes that issue.
Closes: #1875