Skip to content

Add participant type to test user and simplify enum handling in checkin #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
euxzy wants to merge 1 commit into from
Closed

Add participant type to test user and simplify enum handling in checkin #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions routes/tests/test_checkin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def setUp(self) -> None:
last_name="user",
password=generate_hash_password("password"),
is_active=True,
participant_type="Student"
)
self.db.add(self.test_user)
self.db.commit()
Expand Down
6 changes: 2 additions & 4 deletions schemas/checkin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ def user_model_to_checkin_response(user: User) -> CheckinUserResponse:
tshirt_size = None
participant_type = None
try:
tshirt_size = TShirtSize(user.t_shirt_size) if user.t_shirt_size else None
participant_type = (
ParticipantType(user.participant_type) if user.participant_type else None
)
tshirt_size = user.t_shirt_size
participant_type = user.participant_type
except ValueError as e:
logger.error(f"Invalid enum value in user model: {e}")

Expand Down
Loading