Conversation
alex
approved these changes
Apr 8, 2026
Member
|
Before I merge, have we confirmed these vectors are useful for us (i.e., they are usable as seed only)? |
Contributor
Author
|
Yes, the format is described here: MLKEM#file-format On the 11 fields we are using:
And the four that we do not use:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #14598 , this PR adds KAT for ML-KEM.\
Warning: the test vectors are heavy (36 MB) because they contain 1000 vectors, and it bumps the total size of the vectors in the repo by 30%! For comparison, ML-DSA only has 100 vectors.
At the moment in the PR, I have kept the files as-is, but I think we could trim them down to only the first hundred vectors each. WDYT?