Skip to content

fix: support ast.Index, ast.ExtSlice in py3.8 when use subscript #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FLming wants to merge 1 commit into from
Closed

fix: support ast.Index, ast.ExtSlice in py3.8 when use subscript #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions varname/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,15 @@ def node_name(

name = type(node).__name__
if isinstance(node, ast.Subscript):
node_slice = node.slice
if isinstance(node_slice, ast.Index):
node_slice = node.slice.value
elif isinstance(node_slice, ast.ExtSlice):
node_slice = ast.Tuple(node_slice.dims)
try:
return f"{node_name(node.value)}[{node_name(node.slice, True)}]"
return f"{node_name(node.value)}[{node_name(node_slice, True)}]"
except ImproperUseError:
name = f"{node_name(node.value)}[{type(node.slice).__name__}]"
name = f"{node_name(node.value)}[{type(node_slice).__name__}]"

raise ImproperUseError(
f"Node {name!r} detected, but only following nodes are supported: \n"
Expand Down