docs(get-functions): add warning about resource lookup failures#18269
docs(get-functions): add warning about resource lookup failures#18269pierskarsenbarg wants to merge 3 commits intomasterfrom
Conversation
Docs ReviewScope: This is a clean, well-scoped change. Two minor suggestions: Suggestions
What looks good
No blocking issues. This is ready to merge as-is, though the suggestions above could improve clarity. Mention @claude if you'd like additional reviews or help with changes. |
|
Your site preview for commit 0b2b807 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18269-0b2b807c.s3-website.us-west-2.amazonaws.com. |
|
@claude review changes |
|
Claude finished @pierskarsenbarg's task in 41s —— View job Docs Review
File: This is a clean, well-scoped change. Here's what I found: What looks good
Minor suggestions
SummaryNo blocking issues. This PR is in good shape and ready to merge. |
|
Your site preview for commit 1c8b4da is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18269-1c8b4da1.s3-website.us-west-2.amazonaws.com. |
|
A counter-nitpick: I preferred your original wording because it hints at a possible way of dealing with the error but that would probably need more explanation about the caveats of handling exceptions. |
|
Your site preview for commit 0c62c88 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18269-0c62c88a.s3-website.us-west-2.amazonaws.com. |
Summary
Test plan