Conversation
|
Your site preview for commit f1a7924 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-f1a79240.s3-website.us-west-2.amazonaws.com. |
Docs Review — PR #18051Issues
Suggestions
What looks good
Publishing readiness checklist
Mention @claude in a comment if you'd like additional reviews or fixes. |
f1a7924 to
c91aad8
Compare
Docs Review — PR #18051Scope: Overall this is a well-structured, clearly written blog post. The conversion guide is particularly useful — breaking it into numbered steps with before/after examples makes it easy to follow. A few items to address before merging: Issues
Suggestions
Publishing readiness checklist
Mention @claude if you'd like additional reviews or automated fixes. |
|
Your site preview for commit c91aad8 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-c91aad84.s3-website.us-west-2.amazonaws.com. |
|
|
||
| ```typescript | ||
| // CommonJS (Node.js default) | ||
| const pulumi = require("@pulumi/pulumi"); |
There was a problem hiding this comment.
In our docs, we don't do this: https://www.pulumi.com/registry/packages/aws/api-docs/account/region/#example-usage
There was a problem hiding this comment.
I updated the ESM section to talk about export = ... instead, a case we actually do have in our documentation.
|
|
||
| ```typescript | ||
| // CommonJS | ||
| module.exports = { bucketName: bucket.id }; |
There was a problem hiding this comment.
We don't do this in our docs: https://www.pulumi.com/docs/iac/concepts/stacks/#outputs
Co-authored-by: Piers Karsenbarg <piers@pulumi.com>
|
Your site preview for commit db6031e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-db6031e0.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit df250a9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-df250a9d.s3-website.us-west-2.amazonaws.com. |
cnunciato
left a comment
There was a problem hiding this comment.
Super stoked to see this and can't wait build out more content around it. 🔥
| - **Fast package management**: Bun's built-in package manager can install dependencies significantly faster than npm. | ||
| - **Node.js compatibility**: Bun [aims for 100% Node.js compatibility](https://bun.sh/docs/runtime/nodejs-apis), so the npm packages you already use with Pulumi should work out of the box. | ||
|
|
||
| With `runtime: bun`, Pulumi uses Bun for both running your program and managing your packages, giving you a streamlined single-tool experience. |
There was a problem hiding this comment.
Presumably also much faster startup times, native ESM support for Pulumi programs, all the goodies that come with that, etc.?
There was a problem hiding this comment.
native ESM support for Pulumi programs
Pulumi supports native ESM just fine with Node.js, but we don't default to it.
I don't think the startup time matters much, so I'd rather not talk about better performance when it's unlikely to meaningfully impact the total duration of the operation.
| - **Node.js compatibility**: Bun [aims for 100% Node.js compatibility](https://bun.sh/docs/runtime/nodejs-apis), so the npm packages you already use with Pulumi should work out of the box. | ||
|
|
||
| With `runtime: bun`, Pulumi uses Bun for both running your program and managing your packages, giving you a streamlined single-tool experience. | ||
|
|
There was a problem hiding this comment.
This is all good, but one thing that feels like it's somewhat missing (and could add a bit of color) is an answer to the the question, "What took you so long?" 😄 Looking back at the issue, it seems the missing piece was mainly support for http2, but as a user of both Bun and Pulumi, I'd love to hear more about how that matters and whether we hit any other issues along the way. Not a deep dive of course, just a bit more of the technical story (as it's probably pretty interesting!).
We should also update Piers's post to revise the bit about only supporting package management. I'm happy to take that on if you like — up to you!
There was a problem hiding this comment.
Apparently bun started supporting GRPC on the server side in https://bun.sh/blog/bun-v1.1.31#support-for-node-http2-server-and-grpc in October 18, 2024. So I think the main reason we didn't support it as a runtime earlier was that we didn't get around to it.
|
Your site preview for commit 9665f29 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-9665f292.s3-website.us-west-2.amazonaws.com. |
Co-authored-by: Christian Nunciato <c@nunciato.org>
Co-authored-by: Christian Nunciato <c@nunciato.org>
|
Your site preview for commit 6523476 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-65234764.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit a8bae00 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18051-a8bae00b.s3-website.us-west-2.amazonaws.com. |
|
I think this is ready to go, we only need to update the date for the post. |
Requires CLI 3.227.0 (about to be released) and@pulumi/pulumi3.226.0 (already released)Edit: everything's been released
Need to first merge:
Fixes #18052