Skip to content

Fix / quarantine more flaky specs #7075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tpendragon merged 3 commits into from
Mar 2, 2026
Merged

Fix / quarantine more flaky specs #7075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ee930a
Mark another storage adapter spec flaky
hackartisan Feb 26, 2026
b09711b
Ensure save is complete before fetching the resource
hackartisan Feb 26, 2026
0d4d960
Go ahead and quarantine the last storage adapter shared spec
hackartisan Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion spec/adapters/fallback_disk_adapter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
require "valkyrie/specs/shared_specs"

RSpec.describe FallbackDiskAdapter do
it_behaves_like "a Valkyrie::StorageAdapter"
# for background on :flaky tag see comment on Bagit::StorageAdapter
context "shared specs", :flaky do
it_behaves_like "a Valkyrie::StorageAdapter"
end
let(:storage_adapter) do
described_class.new(
primary_adapter: primary_adapter,
Expand Down
5 changes: 4 additions & 1 deletion spec/adapters/retrying_disk_adapter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
require "valkyrie/specs/shared_specs"

RSpec.describe RetryingDiskAdapter do
it_behaves_like "a Valkyrie::StorageAdapter"
# for background on :flaky tag see comment on Bagit::StorageAdapter
context "shared specs", :flaky do
it_behaves_like "a Valkyrie::StorageAdapter"
end
let(:storage_adapter) do
described_class.new(
inner_adapter
Expand Down
3 changes: 2 additions & 1 deletion spec/features/vector_resource_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
sign_in user
end

scenario "creating a new resource and viewing geoblacklight document", :flaky, js: true do
scenario "creating a new resource and viewing geoblacklight document", js: true do
visit new_vector_resource_path

fill_in "vector_resource_source_metadata_identifier", with: "99100017893506421"
fill_in "Local identifier", with: "local_id"
click_button "Save"
expect(page).to have_css(".table-heading", text: "Attributes")

qs = ChangeSetPersister.default.query_service
id = qs.find_all_of_model(model: VectorResource).first.id.to_s
Expand Down