Added the missing closing body tags to export.html and select.html#1227
Added the missing closing body tags to export.html and select.html#1227abba-danmusa wants to merge 4 commits intopubliclab:mainfrom
Conversation
|
Thanks for opening this pull request! |
|
hi @abba-danmusa , could you please add the link to the issue you are fixing with this PR |
|
Sure.
…Sent from my iPhone
On 24 Oct 2022, at 1:42 PM, Cess ***@***.***> wrote:
hi @abba-danmusa , could you please add the link to the issue you are fixing with this PR
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
This is the link to the issue #1218 |
cesswairimu
left a comment
There was a problem hiding this comment.
@abba-danmusa could you please check your changes? it seems you touched lines that were not part of the issue
Okay. Am on it |
Fixed |
|
Hi cesswairimu, can you please approve this? |
|
hi @abba-danmusa, I am sorry, it seems the issue you are solving was fixed on this pull request #1247 |
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt testIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!