Open
Conversation
Alex Kiessling (ajkiessl)
requested changes
Jul 29, 2024
Contributor
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
I think we can remove widget.css and widget.css.map. Ultimately, shakapacker should compile the widget.scss into the application.css and application.css.map and throw that in the public/packs/css directory. Otherwise this looks good!
Contributor
|
Also, this should probably be removed in widget.scss: Since shakapacker will handle this. |
Alex Kiessling (ajkiessl)
approved these changes
Jul 30, 2024
Contributor
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
Looks good!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Adds the readability widget developed by NC State Libraries
The only customization at this time is changing to psu brand colors.
Current fields are warm background, highlight links, open dyslexic font, and remove images. There's potential in the future to customize further by changing the fields you can toggle on/off (ex. ADHD friendly fonts, etc)