Skip to content

adds readability widget#1331

Open
Sarah Smulligan (Smullz622) wants to merge 5 commits intomainfrom
preview/readability-widget
Open

adds readability widget#1331
Sarah Smulligan (Smullz622) wants to merge 5 commits intomainfrom
preview/readability-widget

Conversation

@Smullz622
Copy link
Contributor

Adds the readability widget developed by NC State Libraries

The only customization at this time is changing to psu brand colors.

Current fields are warm background, highlight links, open dyslexic font, and remove images. There's potential in the future to customize further by changing the fields you can toggle on/off (ex. ADHD friendly fonts, etc)

Copy link
Contributor

@ajkiessl Alex Kiessling (ajkiessl) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove widget.css and widget.css.map. Ultimately, shakapacker should compile the widget.scss into the application.css and application.css.map and throw that in the public/packs/css directory. Otherwise this looks good!

@ajkiessl
Copy link
Contributor

Also, this should probably be removed in widget.scss:

/*
* to compile run this code from the root of this app
* sass --watch widget.scss:widget.css
*

Since shakapacker will handle this.

Copy link
Contributor

@ajkiessl Alex Kiessling (ajkiessl) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ruthtillman
Copy link
Collaborator

Ruth (ruthtillman) commented Jan 9, 2025

Notes on review!

  1. When we use "Hide images" there isn't any alt text display -- thinking the Libraries in the header, the cover if there is one, and the footer image. I don't know if we want this per se but the links are still there and functioning. I also don't know from an accessibility perspective if this is at all useful. But it's a thing I noticed. If we want to offer Libraries branding at the top in particular, that's getting lost.
  2. The OpenDyslexia font makes the placeholder image for items without covers go squirrely. Is there any way we could exempt it?
    open_dyslexic_font_no_google_cover
  3. Link highlighting doesn't highlight the "Bookmark" button on any kind of show/result page or the "In Bookmarks" one in the Bookmarks section. I assume that's because it's a different kind of action. It's a link-like one and an action a person can take. Would it be too complex to add in?
    bookmarks_highlighting_1
    bookmarks_highlighting_2
    bookmarks_highlighting_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants