WIP upgrade to blacklight 8#1295
Draft
Sarah Smulligan (Smullz622) wants to merge 23 commits intomainfrom
Draft
Conversation
…rails 7 upgrade, this is just a bit of clean up.
…aced render_search_bar. Without the partial, advanced search and start over link were not rendering. I added them back into the search bar and added a test so if it disappears again we will know
…r_document_main_content_partial, and document_show_html_title
…ctionality are now in core blacklight so upgrading the gem meant moving a lot of our gem overrides to core bl overrides. While this is functional as is, many of the methods in advanced_search_facets_as_select will be depreciated in BL 8 so that it still a work in progress.
…ress depreciations
… ActionComponent instead. The url method got messed up with our ris and bulk_ris actions so I did a quick fix. Ideally, we will go back and refine this a bit
… document RIS needed to be adjusted accordingly as well.
… with the BL 8 upgrade and Ruth gave the ok to just remove them
…is modifies how session_tracking_params is called as well
Alex Kiessling (ajkiessl)
requested changes
Jul 2, 2024
Contributor
Alex Kiessling (ajkiessl)
left a comment
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
So far this looks good. There's a lot here so I'm kind of skimming over a lot of things, but there was only one thing that stood out to me.
| @@ -1,4 +1,5 @@ | |||
| # frozen_string_literal: true | |||
Contributor
There was a problem hiding this comment.
This file can be removed since we're on rails 7 now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1289