Skip to content

Fix #493: Add missing @method annotations to FFMpeg facade - #582

Open
realpascalbotjet wants to merge 1 commit into
protonemedia:mainfrom
realpascalbotjet:fix/issue-493
Open

Fix #493: Add missing @method annotations to FFMpeg facade#582
realpascalbotjet wants to merge 1 commit into
protonemedia:mainfrom
realpascalbotjet:fix/issue-493

Conversation

@realpascalbotjet

Copy link
Copy Markdown
Collaborator

Summary

Fixes #493.

This is not a code bug — the exportTile() method is correctly defined on MediaOpener (line 209) and works at runtime. The reported error is most likely caused by using an older version of the package that predates the addition of exportTile().

However, the FFMpeg facade was missing @method PHPDoc annotations for several public methods on MediaOpener, including exportTile(), export(), exportForHLS(), exportFramesByAmount(), exportFramesByInterval(), and openWithInputOptions(). This causes IDEs and static analysis tools (PHPStan, Psalm, Larastan) to report these methods as undefined, which can lead to confusion.

This PR adds the missing @method annotations to the facade docblock.

Changes

  • Added @method annotations to FFMpeg facade for:
    • openWithInputOptions()
    • export()
    • exportForHLS()
    • exportTile()
    • exportFramesByAmount()
    • exportFramesByInterval()

Test plan

  • No runtime behavior changes — PHPDoc annotations only
  • Verified all annotated methods exist on MediaOpener with matching signatures
  • Existing test suite (TileTest) covers exportTile() functionality

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call to undefined method ProtoneMedia\LaravelFFMpeg\MediaOpener::exportTile()

1 participant