Fix #493: Add missing @method annotations to FFMpeg facade - #582
Open
realpascalbotjet wants to merge 1 commit into
Open
Fix #493: Add missing @method annotations to FFMpeg facade#582realpascalbotjet wants to merge 1 commit into
realpascalbotjet wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #493.
This is not a code bug — the
exportTile()method is correctly defined onMediaOpener(line 209) and works at runtime. The reported error is most likely caused by using an older version of the package that predates the addition ofexportTile().However, the
FFMpegfacade was missing@methodPHPDoc annotations for several public methods onMediaOpener, includingexportTile(),export(),exportForHLS(),exportFramesByAmount(),exportFramesByInterval(), andopenWithInputOptions(). This causes IDEs and static analysis tools (PHPStan, Psalm, Larastan) to report these methods as undefined, which can lead to confusion.This PR adds the missing
@methodannotations to the facade docblock.Changes
@methodannotations toFFMpegfacade for:openWithInputOptions()export()exportForHLS()exportTile()exportFramesByAmount()exportFramesByInterval()Test plan
MediaOpenerwith matching signaturesTileTest) coversexportTile()functionality🤖 Generated with Claude Code