Optimize parsing packed repeated fields: #25034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If counting varints revealed that each varint takes one byte, skip varint parsing. Idea by sbenza@. * Do not check if all varints necessarily fit under the current capacity, which was done to skip counting varints. Counting varints is now useful also to check if each varint takes one byte, and it is now cheap enough to perform unconditionally. There were actually two capacity checks by mistake, and in the case of enough capacity we were doing a slower loop with Add instead of a faster loop with setting an element. * For bool, check if each byte in the array is a valid representation for a bool, i.e. 0 or 1. If so, skip varint parsing and bool normalization. PiperOrigin-RevId: 848498407
copybara-service
bot
force-pushed
the
test_848498407
branch
from
be37aa0 to
edaaa29
Compare
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize parsing packed repeated fields:
If counting varints revealed that each varint takes one byte, skip varint
parsing. Idea by sbenza@.
Do not check if all varints necessarily fit under the current capacity,
which was done to skip counting varints. Counting varints is now useful
also to check if each varint takes one byte, and it is now cheap enough
to perform unconditionally.
There were actually two capacity checks by mistake, and in the case of
enough capacity we were doing a slower loop with Add instead of a faster
loop with setting an element.
For bool, check if each byte in the array is a valid representation for
a bool, i.e. 0 or 1. If so, skip varint parsing and bool normalization.