release: add lib/ micromodules to release-please#2132
Open
overbalance wants to merge 1 commit intoprotobufjs:masterfrom
Open
release: add lib/ micromodules to release-please#2132overbalance wants to merge 1 commit intoprotobufjs:masterfrom
overbalance wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/independently-published@protobufjs/*packages to release-please manifest mode config.release-please-manifest.jsonwith current versions from each package'spackage.jsoncommand: manifestpicks up the new entriesMotivation
The
lib/micromodules have never been tracked by release-please, so fixes merged tomasterwere never published to npm. This has caused multiple issues:Directly addresses:
@protobufjs/utf8on npm is still the old code versionevaltriggers security warning in the terminal #2057 —@protobufjs/inquireeval fix merged but never published@protobufjs/codegenand@protobufjs/fetchfixes in git but not on npm@protobufjs/inquirefix never published)Related release pipeline issues:
Unblocks future releases for open PRs that touch lib/:
lib/utf8)lib/codegen)lib/inquire)Test plan
node -e "require('./release-please-config.json'); require('./.release-please-manifest.json')")