Fixed case of struct.proto fields to match protobuf definition#2119
Open
dlizewski wants to merge 1 commit intoprotobufjs:masterfrom
Open
Fixed case of struct.proto fields to match protobuf definition#2119dlizewski wants to merge 1 commit intoprotobufjs:masterfrom
dlizewski wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
dlizewski
changed the title
dlizewski
force-pushed
the
fix/structCase
branch
from
2bf95c9 to
297bf8d
Compare
Contributor
|
I believe this is fundamentally a correct change but if I understand correctly, it will be breaking for existing code that expects camelCase there, so I'm not sure we can safely merge this without breaking code that depends on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed case of fields in common.js "struct" to match the case in the original struct.proto
https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/struct.proto#L66
Matching the case as the original protobuf allows the json representation to match the protobuf defintion with or without the keepCase option.