Improve decoding performance by 40% by preallocating arrays of known length#2033
Open
adriancable wants to merge 1 commit intoprotobufjs:masterfrom
Open
Improve decoding performance by 40% by preallocating arrays of known length#2033adriancable wants to merge 1 commit intoprotobufjs:masterfrom
adriancable wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
itsfolf
added a commit
to UncollapseCo/protobuf.js
that referenced
this pull request
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the generated
.fromObjectmethods contain code like this:This is bad, because you're doing
m.properties.lengthallocations. We can do better since the size of the array is known:This PR improves decode performance on the benchmark by around 40% (similar gains in the real world, too).
Before:
After: