suggests using docker compose to provision dev dbs #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Adolf <[email protected]>
rrrliu
reviewed
Jan 13, 2025
Contributor
rrrliu
left a comment
rrrliu
left a comment
There was a problem hiding this comment.
Thanks for this and apologies for the late review! It'd be great to dockerize more items going forward.
Left one comment -- also looks like there are some merge conflicts.
Contributor
There was a problem hiding this comment.
Could you add instructions here for installing Docker and starting the Docker daemon, before calling any of the localdb scripts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.