feat: allow display_hint config for indexes#1610
Open
jonaskuske wants to merge 1 commit intoprometheus:mainfrom
Open
feat: allow display_hint config for indexes#1610jonaskuske wants to merge 1 commit intoprometheus:mainfrom
jonaskuske wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Jonas Kuske <mail@jonaskuske.com>
jonaskuske
force-pushed
the
feat/display-hints-for-index-oid-strings
branch
from
4041cd7 to
accdeab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1549, support for DISPLAY-HINT was added for metrics/lookups. However, this does not cover labels/strings coming from Index OIDs.
This PR extends the
Indextype andindexOidsAsStringfunction to also handle display hints. This allows e.g. cases where IP addresses are used as index in OctetString format.I was not sure how to best integrate this into the generator and its config, so I've left this part out of the PR for now. Happy to receive some pointers on how this could be integrated into the generator step, otherwise this could be merged as-is and require manual config adjustment for now, and generator functionality could come later?