Add IO stats and ext4 FS stats through new ext4 collector#3577
Open
john-morales wants to merge 10 commits intoprometheus:masterfrom
Open
Add IO stats and ext4 FS stats through new ext4 collector#3577john-morales wants to merge 10 commits intoprometheus:masterfrom
john-morales wants to merge 10 commits intoprometheus:masterfrom
Conversation
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
…iskstats Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
Signed-off-by: John Morales <[email protected]>
anarcat
reviewed
Mar 9, 2026
Comment on lines
+773
to
+781
| # HELP node_ext4_errors_total Number of ext4 filesystem errors. | ||
| # TYPE node_ext4_errors_total counter | ||
| node_ext4_errors_total{device="sdb1"} 12 | ||
| # HELP node_ext4_messages_total Number of ext4 filesystem log messages. | ||
| # TYPE node_ext4_messages_total counter | ||
| node_ext4_messages_total{device="sdb1"} 567 | ||
| # HELP node_ext4_warnings_total Number of ext4 filesystem warnings. | ||
| # TYPE node_ext4_warnings_total counter | ||
| node_ext4_warnings_total{device="sdb1"} 34 |
Contributor
There was a problem hiding this comment.
given that sda is a device in node_disk_ioerr_total, perhaps sdb1 in node_ext4_warnings_total should be a partition?
…ition instead of device Signed-off-by: John Morales <[email protected]>
Author
|
Updated ext4 metrics label from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to revive Issue #3005 / Pull Request #3295 via implementing support for
ext4andfserror statistics through use of the procfs library.Work here builds on the progress from #3295. I'm unclear myself if/how to properly attribute @mshahzeb's efforts, but happy to do so.
Re-iterating the original goals, this PR implements support for:
...from:
And implements support for:
...from:
The new
ext4collector is enabled by default. It also has support for (mutually exclusive)partition-excludeandpartition-includeregexp flags, which seemed to be a standard practice just from my looking around at other disk-related collectors. I also elected to make the defaultpartition-excludeequal to^features$, to intentionally avoid the built-in"features"directory at/sys/fs/ext4/features. It is not a real partition, and does not contain the 3errors_count,warning_count,msg_countmetrics the collector emits.Corresponding procfs change that enabled this work: prometheus/procfs#651
Thank you for your consideration!