feat: add label_name_underscore_sanitization and label_name_preserve_multiple_underscores to OTLPConfig #8562
Open
dongjiang1989 wants to merge 3 commits into
Open
Conversation
…multiple_underscores to OTLPConfig Signed-off-by: dongjiang <[email protected]>
8fc260e to
f93fa91
Compare
Signed-off-by: dongjiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
ref: prometheus/prometheus#17345
labelNameUnderscoreSanitizationandlabelNamePreserveMultipleUnderscoresfields to theOTLPConfigtype in the Prometheus CRD.translation_strategyuses underscore escaping (UnderscoreEscapingWithSuffixesorUnderscoreEscapingWithoutSuffixes).labelNameUnderscoreSanitizationcontrols whether to prependkey_to labels starting with_(reserved labels starting with__are not modified).labelNamePreserveMultipleUnderscoresenables preserving multiple consecutive underscores in label names during sanitization (defaults totrue).If you're contributing for the first-time, check our contribution guidelines.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.