Add support for multiple CCISS devices#274
Open
j-addante wants to merge 5 commits intoprometheus-community:masterfrom
Open
Add support for multiple CCISS devices#274j-addante wants to merge 5 commits intoprometheus-community:masterfrom
j-addante wants to merge 5 commits intoprometheus-community:masterfrom
Conversation
|
selfish bump. youd have to sign your commit and check spelling |
added 4 commits
March 8, 2025 15:18
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
j-addante
force-pushed
the
support_multiple_cciss_devices
branch
from
eecbad1 to
dee392b
Compare
Signed-off-by: Josh <[email protected]>
|
another selfish bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on #257 to add support for CCISS devices. The underlying code for creating the device label is correct, unfortunately how SMARTCTL reports the device names and type is not as expected. This should also close out issue #26.