Conversation
Signed-off-by: Moritz Poldrack <m.poldrack@babiel.com>
|
Hi, I just saw this PR, and it is exactly what I need, thank you for creating this @mpldr. Is there anything blocking this from being reviewed or merged? I’d be happy to help test or make updates if needed. |
|
@SuperQ Could you please take a look at this? It would be much easier if it was merged, rather than me having to maintain a local patch and build for my systems. |
ArthurSens
left a comment
There was a problem hiding this comment.
Hi, sorry for the delayed review here! The codebase has been heavily refactored a few months back, so the PR will need a big rebase 😬
Also, we need to have proper test coverage before accepting any PRs.
If you don't mind, could you clarify ehat is the intended use case for the pending_value label? pg_settings.setting contains the currently active value, not the value awaiting restart. Are you trying to expose only which settings require a restart, or also the configured value that will take effect afterward?
|
We could probably re-use the existing settings collector instead of creating a new one too 🤔 |
Produces something along the lines of:
To test: