Add custom list types which are suitable for Reclass's classes and applications arrays#5
Merged
Add custom list types which are suitable for Reclass's classes and applications arrays#5
applications arrays#5Conversation
c701600 to
23c49f5
Compare
…`applications` arrays
… to `List` trait Also implement the methods for `UniqueList` and `RemovableList`
23c49f5 to
1796f03
Compare
mhutter
reviewed
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UniqueListtype corresponds to the Python ReclassClassestype (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/classes.py) and theRemovableListtype corresponds to the Python ReclassApplicationstype (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/applications.py).Notably, the
RemovableListtype incorporates the changes proposed to Python Reclass in kapicorp/reclass#9 which will address the longstanding issue where in some situations it's not possible to remove entries from theapplicationsarray.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog