Skip to content

Add custom list types which are suitable for Reclass's classes and applications arrays#5

Merged
simu merged 4 commits intomainfrom
feat/custom-list-types
Aug 30, 2023
Merged

Add custom list types which are suitable for Reclass's classes and applications arrays#5
simu merged 4 commits intomainfrom
feat/custom-list-types

Conversation

@simu
Copy link
Member

@simu simu commented Aug 30, 2023

The UniqueList type corresponds to the Python Reclass Classes type (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/classes.py) and the RemovableList type corresponds to the Python Reclass Applications type (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/applications.py).

Notably, the RemovableList type incorporates the changes proposed to Python Reclass in kapicorp/reclass#9 which will address the longstanding issue where in some situations it's not possible to remove entries from the applications array.

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Aug 30, 2023
@simu simu force-pushed the feat/custom-list-types branch 3 times, most recently from c701600 to 23c49f5 Compare August 30, 2023 12:53
@simu simu force-pushed the feat/custom-list-types branch from 23c49f5 to 1796f03 Compare August 30, 2023 12:56
@simu simu marked this pull request as ready for review August 30, 2023 13:05
@simu simu requested a review from a team August 30, 2023 13:05
Copy link
Member

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serde is cool 😊

@simu simu merged commit cca5463 into main Aug 30, 2023
@simu simu deleted the feat/custom-list-types branch August 30, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants