Skip to content

Refactor alert filtering #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
simu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor alert filtering #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion class/defaults.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ parameters:
backupcommandannotation: k8up.syn.tools/backupcommand
tz: Europe/Zurich
alert_rule_filters:
namespace: namespace=~"syn.*"
namespace:
match_re: "syn.*"
prometheus_push_gateway: 'http://platform-prometheus-pushgateway.syn-synsights.svc:9091'
monitoring_enabled: true
charts:
Expand Down
26 changes: 24 additions & 2 deletions component/monitoring.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,29 @@ local service_monitor = com.namespaced(params.namespace, {
},
});

local alert_selector(filters) =
local op = {
exclude: '!=',
exclude_re: '!~',
match: '=',
match_re: '=~',
};
local selector(sel) = [
{
op: op[s],
val: sel[s],
}
for s in std.objectFields(sel)
];
if filters != null then
local selectors = std.mapWithKey(
function(key, sel) ([ '%s%s"%s"' % [ key, s.op, s.val ] for s in selector(sel) ]),
filters
);
std.join(',', std.flattenArrays([ selectors[f] for f in std.objectFields(selectors) ]))
else
'';

local alert_rules = com.namespaced(params.namespace, {
apiVersion: 'monitoring.coreos.com/v1',
kind: 'PrometheusRule',
Expand All @@ -50,8 +73,7 @@ local alert_rules = com.namespaced(params.namespace, {
annotations: {
message: 'Last backup for PVC {{ $labels.pvc }} in namespace {{ $labels.instance }} had {{ $value }} errors',
},
expr: 'baas_backup_restic_last_errors{%s} > 0' %
com.getValueOrDefault(params.alert_rule_filters, 'namespace', ''),
expr: 'baas_backup_restic_last_errors{%s} > 0' % alert_selector(params.alert_rule_filters),
'for': '1m',
labels: {
severity: 'critical',
Expand Down