Skip to content

provisioner: Increase CPU limit for shutdown-manager#7382

Merged
tsaarni merged 1 commit intoprojectcontour:mainfrom
Nordix:gateway-provisioner-envoy-shutdown-resource-limt
Feb 4, 2026
Merged

provisioner: Increase CPU limit for shutdown-manager#7382
tsaarni merged 1 commit intoprojectcontour:mainfrom
Nordix:gateway-provisioner-envoy-shutdown-resource-limt

Conversation

@tsaarni
Copy link
Member

@tsaarni tsaarni commented Jan 21, 2026

When using the Contour Gateway Provisioner, the shutdown-manager container was reported to experience CPU throttling because the default limit (50m) was too low for some environments.

This change increases the CPU limit to 200m. This hopefully fixes the throttling without needing any configuration changes from users. This limit is high, but it shouldn't cause problems because the shutdown-manager logic is very simple and it is unlikely to start e.g. running in a busy loop. I kept the request unchanged, so the change should not impact e.g. dimensioning of resources.

This PR doesn't make the limits or requests configurable for users.

Updates #7366

@tsaarni tsaarni requested a review from a team as a code owner January 21, 2026 20:08
@tsaarni tsaarni requested review from sunjayBhatia and removed request for a team January 21, 2026 20:08
@sunjayBhatia sunjayBhatia requested review from a team, clayton-gonsalves and izturn and removed request for a team January 21, 2026 20:08
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.76%. Comparing base (07a2134) to head (dc3b19a).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7382      +/-   ##
==========================================
- Coverage   81.85%   81.76%   -0.09%     
==========================================
  Files         130      130              
  Lines       15747    15747              
==========================================
- Hits        12889    12876      -13     
  Misses       2574     2574              
- Partials      284      297      +13     
Files with missing lines Coverage Δ
...nternal/provisioner/objects/dataplane/dataplane.go 84.03% <ø> (-3.65%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tsaarni tsaarni force-pushed the gateway-provisioner-envoy-shutdown-resource-limt branch from c656b7b to dc3b19a Compare January 21, 2026 20:16
@tsaarni tsaarni added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 21, 2026
@tsaarni tsaarni merged commit a826acd into projectcontour:main Feb 4, 2026
27 of 28 checks passed
tsaarni added a commit to Nordix/contour that referenced this pull request Feb 7, 2026
tsaarni added a commit that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/small A small change that needs one line of explanation in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants