Investigate why hashrelease build is dirty#12172
Open
nelljerram wants to merge 1 commit intoprojectcalico:masterfrom
Open
Investigate why hashrelease build is dirty#12172nelljerram wants to merge 1 commit intoprojectcalico:masterfrom
nelljerram wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
nelljerram
added
release-note-not-required
Contributor
There was a problem hiding this comment.
Pull request overview
Adds visibility into repository state during Calico release publishing by introducing a GitStatus helper and logging git status output as part of publish preflight validation.
Changes:
- Add
utils.GitStatus(dir)wrapper aroundgit status. - Log git status output during
CalicoManager.publishPrereqs()before checking for a dirty repo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| release/pkg/manager/calico/manager.go | Logs git status during publish prerequisites validation. |
| release/internal/utils/git.go | Introduces GitStatus() helper that runs git status. |
Comment on lines
+906
to
908
| status, _ := utils.GitStatus(r.repoRoot) | ||
| logrus.Infof("Git status:\n%v", status) | ||
| if dirty, err := utils.GitIsDirty(r.repoRoot); dirty || err != nil { |
|
|
||
| // GitStatus returns the current git status of the repository. | ||
| func GitStatus(dir string) (string, error) { | ||
| return command.GitInDir(dir, "status") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: