[WIP] Fix ClusterNetworkPolicy conformance test#11663
Closed
mazdakn wants to merge 26 commits intoprojectcalico:masterfrom
Closed
[WIP] Fix ClusterNetworkPolicy conformance test#11663mazdakn wants to merge 26 commits intoprojectcalico:masterfrom
mazdakn wants to merge 26 commits intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
Contributor
There was a problem hiding this comment.
Pull request overview
This is a work-in-progress PR that aims to fix ClusterNetworkPolicy conformance tests by replacing a remote network-policy-api dependency with a local submodule, enabling debugging, and modifying test execution parameters.
Changes:
- Replaced remote network-policy-api dependency with local submodule reference
- Added debug logging and hardcoded test configuration values for troubleshooting
- Modified Makefile to enable verbose output and change test focus patterns
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| network-policy-api | Added as a new git submodule at a specific commit |
| go.mod | Updated to use local network-policy-api submodule instead of remote version |
| go.sum | Removed checksums for the previously used remote network-policy-api version |
| e2e/cmd/clusternetworkpolicy/e2e_test.go | Added debug logging and hardcoded test configuration for troubleshooting |
| e2e/Makefile | Added GODEBUG environment variable to force Go DNS resolver |
| Makefile | Modified e2e test execution to focus on ClusterNetworkPolicy tests with verbose output |
| e2e/cmd/k8s/e2e_test.go | Commented out network-policy-api conformance import |
mazdakn
added
docs-not-required
marvin-tigera
removed
docs-not-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.